Found some time to review and test this patch. Quite long series. Include: - style updates; - handle some weird cases; - fix minor bugs; - change interface to reduce changes to reds-stream.c; - handle PING and PONG. Perhaps I would rename RedsWebSocket to just WebSocket and websocket_frame_t which appear quite weird (all other structure names use CamelCase). I think lot of patches should be merged to the original one. Frediano Ziglio (29): Fix include order Terminate HTTP header Some style changes Use len parameter directly Don't use literal 125 constant as confusing Remove useless assignment Remove useless check Avoid to fill header if not needed Move RedsWebSocket to header Make websocket function more ABI compatibles with RedsStream Make websocket_ack_close static New interface to create RedsWebSocket Fix check for header Fix typo in comment Better encapsulation Avoid to return value not used Use gboolean instead of bool for reds_stream_is_websocket Assure HTTP header is proper terminated Update style Minor optimization Group common error code Propagate some variable Use mnemonic for frame type 0 Avoid possible server crash using websockets Support correctly protocol values Handle case if server cannot write the header entirely Simplify and fix constrain_iov Avoids to write close frame in the middle of data Handle PING and PONG frames Jeremy White (1): Add support for clients connecting with the WebSocket protocol. server/Makefile.am | 2 + server/reds-stream.c | 78 ++++++ server/reds-stream.h | 2 + server/reds.c | 13 + server/websocket.c | 697 +++++++++++++++++++++++++++++++++++++++++++++++++++ server/websocket.h | 30 +++ 6 files changed, 822 insertions(+) create mode 100644 server/websocket.c create mode 100644 server/websocket.h -- 2.7.4 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel