Hey, thanks for the work on that, series looks good to me, only one comment on patch 3 Apart from this comment, Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> On Thu, Nov 17, 2016 at 12:15:00PM +0000, Frediano Ziglio wrote: > RC files contain version information. > Update them based on git/configure version. > > Patches work on both Windows using Visual Studio and Linux > using MingW. > > Frediano Ziglio (4): > Convert resource information to English > Move common resource code to a common file > build: Automatically update version/copyright in version.rc > build: Package zip file > > Makefile.am | 2 ++ > common/version.rc | 51 +++++++++++++++++++++++++++++++++++++++++ > configure.ac | 8 ++++++- > vdagent/vdagent.rc | 61 ++++++++++++++------------------------------------ > vdservice/vdservice.rc | 61 ++++++++++++++------------------------------------ > 5 files changed, 94 insertions(+), 89 deletions(-) > create mode 100644 common/version.rc > > -- > 2.7.4 > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel