>
> On Wed, Nov 16, 2016 at 10:10:01AM +0100, Pavel Grunt wrote:
> > ---
> > server/reds.c | 2 +-
> > server/tests/spice-codecs-parsing-test.c | 1 +
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/server/reds.c b/server/reds.c
> > index 12a274c..eccc2ba 100644
> > --- a/server/reds.c
> > +++ b/server/reds.c
> > @@ -3639,7 +3639,7 @@ static void reds_set_video_codecs(RedsState *reds,
> > const char *codecs)
> > {
> > char *encoder_name, *codec_name;
> >
> > - if (strcmp(codecs, "auto") == 0) {
> > + if (codecs == NULL || strcmp(codecs, "auto") == 0) {
> > codecs = default_video_codecs;
>
> Or just if (g_strcmp0(codecs, "auto") == 0) {}
>
>
> Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
>
What's the reason to allows NULL ?
Personally I would nack this patch.
Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel