Re: [PATCH spice-server v2 3/4] sound: Remove sin field from SpicePlaybackState and SpiceRecordState

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-11-15 at 11:23 +0100, Christophe Fergeau wrote:
> This would have deserved a "why?" in the log even if it's just a few
> lines (something like "it's redundant because all we need is sin->st
> which we can pass directly/get directly from yyy").
> 
> In my opinion, commits with only a short log are only acceptable
> for the most trivial of commits, which this one is not.
> 
> Christophe


I agree (even though I already acked the patch)

Jonathon

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]