Re: [spice-gtk v1 4/5] win-usb-dev: Let finalize do libusb_exit()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 15, 2016 at 12:26:54AM +0100, Victor Toso wrote:
> From: Victor Toso <me@xxxxxxxxxxxxxx>
> 
> This fixes a hanging on mingw-spice-gtk when the GUdevClient fails to
> initialize due problems in the UsbDk installation.

"This fixes a hang in mingw-spice-gtk ... due to problems ..."
I'd change the shortlog to _finalize() or finalize() so that it's clear
that it's a method name.

> 
> The libusb_exit() will be called on priv->ctx in
> g_udev_client_initable_init() and also it will be called on NULL at
> g_udev_client_finalize(), making the application hang on
> initialization.

On initialization? Is this because g_udev_client_finalize() is going to
get called when g_udev_client_initable_init() fails?

Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>


Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]