Why I was looking at the way to remove the Dummy* objects I found some duplication and some way to reuse some similar code. Record and playback are quite similar. Frediano Ziglio (5): sound: Move volume field to SndWorker sound: Minor simplification due to volume move sound: Move frequency field to SndWorker sound: Reuse code for spice_server_get_best_{record,playback}_rate sound: Peep hole optimisation server/sound.c | 188 ++++++++++++++++++++++++--------------------------------- 1 file changed, 79 insertions(+), 109 deletions(-) -- 2.7.4 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel