On Wed, 2016-11-09 at 10:19 +0000, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
> server/gstreamer-encoder.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
> index 3d5f8a0..54e1b2e 100644
> --- a/server/gstreamer-encoder.c
> +++ b/server/gstreamer-encoder.c
> @@ -969,11 +969,7 @@ static gboolean create_pipeline(SpiceGstEncoder
> *encoder)
> encoder->gstenc = gst_bin_get_by_name(GST_BIN(encoder-
> >pipeline), "encoder");
> encoder->appsink =
> GST_APP_SINK(gst_bin_get_by_name(GST_BIN(encoder->pipeline),
> "sink"));
>
> -#ifdef HAVE_GSTREAMER_0_10
> - GstAppSinkCallbacks appsink_cbs = {NULL, NULL, &new_sample,
> NULL, {NULL}};
> -#else
> - GstAppSinkCallbacks appsink_cbs = {NULL, NULL, &new_sample,
> {NULL}};
> -#endif
> + GstAppSinkCallbacks appsink_cbs = {NULL, NULL, &new_sample,
> ._gst_reserved = {NULL}};
> gst_app_sink_set_callbacks(encoder->appsink, &appsink_cbs,
> encoder, NULL);
>
> /* Hook into the bus so we can handle errors */
Personal preference, I suppose. This doesn't seem simpler to me since
it mixes order-based initialization and name-based initialization. I
personally find the original to be quicker to comprehend.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel