Hi, On Wed, 2016-10-12 at 11:38 -0400, Marc-André Lureau wrote: > Hi > > ----- Original Message ----- > > Hi, > > > > I plan to merge both uri parsers (one is in spice-session, one in > > spice-uri). > > These patches add more to tests to avoid regressions. > > > > v2 per Victor review splits IPv6 tests and checks for expected > > warnings > > v1: https://lists.freedesktop.org/archives/spice-devel/2016-May/02 > > 9261.html > > Reminds me of https://lists.freedesktop.org/archives/spice-devel/201 > 5-March/019288.html > > It's a shame to see glib so slow at picking the GUri patches. I > personally lost interest, there are other better ways imho. Yes it is > > Tbh, instead of slowly reinventing YA URI parsing in C, The parser is already implemented in spice-gtk (twice). My intention is to have just one parser in spice-gtk, after that it should be easier to migrate another parser, fix bugs etc... > I am tempted to go a step in the future and just link with the rust > URI crate (https://docs.rs/url/1.2.1/url/). Since it's already being > used by firefox in the latest release, I trust this is fairly solid. Probably it is and rust is interesting, but imho it is overkill to use rust just to have better/safer url parsing :) > > I have done some mix of rust and C in the past, just like what Hub > recently described in a blog: https://www.figuiere.net/hub/blog/?201 > 6/10/07/862-rust-and-automake > > It is fairly easy, and I would be happy to link with rust code which > is way safer than C. > > Of course, we would have to keep C for a while, but given that > firefox depends on rust and Fedora ships it, gdb support it etc, > there is a good chance it ends in every single platform we care > about. I'm just curios - do you know if it is currently possible to compile it using mingw ? Anyway I believe that is better to have tests before we change something :) Pavel > > > > > Thanks, > > > > Pavel Grunt (4): > > test-session: Test alternative way for setting port > > test-session: Also test hostname, username and password > > test-session: Test invalid URIs > > test-session: Add IPv6 tests > > > > tests/session.c | 266 > > +++++++++++++++++++++++++++++++++++++++++++++++++++----- > > 1 file changed, 242 insertions(+), 24 deletions(-) > > > > -- > > 2.10.1 > > > > _______________________________________________ > > Spice-devel mailing list > > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/spice-devel > > _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel