Re: [PATCH xf86-video-qxl] Fix crash caused by attempting to access the screen pixmap before it is created

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Hans,


On Tue, Oct 04, 2016 at 02:08:13PM +0200, Hans de Goede wrote:
> qxl_resize_primary_to_virtual() was using pScrn->pScreen != NULL to check
> if createScreenResources has been called. But starting with xserver 1.19
> pScrn->pScreen is non NULL even before createScreenResources is called,
> causing an invalid access to the screenPixmap in
> qxl_resize_primary_to_virtual().
> 
> This commit fixes this.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1381045
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Yes, this was changed in the xserver by
69b782aa75bc06f11b8f9b532d5213f252c4c6c4
"xfree86: Set pScrn->pScreen before driver ScreenInit is called"


Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]