Re: [PATCH v2 6/8] replay: Assure read_binary receives a NULL pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2016-09-15 at 23:19 +0100, Frediano Ziglio wrote:
> read_binary do not allocate a buffer for no-NULL pointers.
> Avoid using uninitialized data and allocate proper buffer.
> 
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
Acked-by: Pavel Grunt <pgrunt@xxxxxxxxxx>
> ---
>  server/red-replay-qxl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
> index ef5569e..45c105c 100644
> --- a/server/red-replay-qxl.c
> +++ b/server/red-replay-qxl.c
> @@ -1089,7 +1089,7 @@ static QXLUpdateCmd
> *red_replay_update_cmd(SpiceReplay *replay)
>  
>  static QXLMessage *red_replay_message(SpiceReplay *replay)
>  {
> -    QXLMessage *qxl;
> +    QXLMessage *qxl = NULL;
>      size_t size;
>  
>      read_binary(replay, "message", &size, (uint8_t**)&qxl,
> sizeof(QXLMessage));
> 
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]