>
> Hi Frediano,
>
> what is the rule ? I prefer to include header if some of its
> declarations is used.
>
It's quite minimal include.
> e.g.: i see that you removed
> #include <spice/vd_agent.h>
> from inputs-channel.h but VDAgentMouseState is used in the file
>
Actually this hunk was in a separate patch with similar rationale.
> Thanks,
> Pavel
>
Frediano
> On Wed, 2016-09-14 at 11:46 +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> > ---
> > server/display-channel.h | 7 +------
> > server/inputs-channel.h | 1 -
> > server/main-dispatcher.h | 1 -
> > server/red-channel.h | 1 -
> > server/red-parse-qxl.h | 1 -
> > server/red-record-qxl.h | 1 -
> > 6 files changed, 1 insertion(+), 11 deletions(-)
> >
> > diff --git a/server/display-channel.h b/server/display-channel.h
> > index 7b71480..9a0277e 100644
> > --- a/server/display-channel.h
> > +++ b/server/display-channel.h
> > @@ -22,27 +22,22 @@
> > #include <common/rect.h>
> >
> > #include "reds-stream.h"
> > -#include "cache-item.h"
> > -#include "pixmap-cache.h"
> > #include "stat.h"
> > #include "reds.h"
> > #include "memslot.h"
> > #include "red-parse-qxl.h"
> > #include "red-record-qxl.h"
> > #include "demarshallers.h"
> > -#include "red-channel.h"
> > #include "red-qxl.h"
> > #include "dispatcher.h"
> > #include "main-channel.h"
> > #include "migration-protocol.h"
> > #include "main-dispatcher.h"
> > -#include "spice-bitmap-utils.h"
> > #include "image-cache.h"
> > #include "utils.h"
> > #include "tree.h"
> > -#include "stream.h"
> > #include "dcc.h"
> > -#include "image-encoders.h"
> > +#include "stream.h"
> >
> > typedef struct DependItem {
> > Drawable *drawable;
> > diff --git a/server/inputs-channel.h b/server/inputs-channel.h
> > index e8f92cc..07a0a22 100644
> > --- a/server/inputs-channel.h
> > +++ b/server/inputs-channel.h
> > @@ -22,7 +22,6 @@
> > // This include should only be used by reds.c and inputs-channel.c
> >
> > #include <stdint.h>
> > -#include <spice/vd_agent.h>
> >
> > #include "red-channel.h"
> >
> > diff --git a/server/main-dispatcher.h b/server/main-dispatcher.h
> > index 9a425de..3e9d9de 100644
> > --- a/server/main-dispatcher.h
> > +++ b/server/main-dispatcher.h
> > @@ -18,7 +18,6 @@
> > #ifndef MAIN_DISPATCHER_H
> > #define MAIN_DISPATCHER_H
> >
> > -#include "spice.h"
> > #include "dispatcher.h"
> > #include "red-channel.h"
> >
> > diff --git a/server/red-channel.h b/server/red-channel.h
> > index 68bfc7a..29754dd 100644
> > --- a/server/red-channel.h
> > +++ b/server/red-channel.h
> > @@ -27,7 +27,6 @@
> > #include <common/ring.h>
> > #include <common/marshaller.h>
> >
> > -#include "spice.h"
> > #include "red-common.h"
> > #include "demarshallers.h"
> > #include "reds-stream.h"
> > diff --git a/server/red-parse-qxl.h b/server/red-parse-qxl.h
> > index 0da20ad..e10f082 100644
> > --- a/server/red-parse-qxl.h
> > +++ b/server/red-parse-qxl.h
> > @@ -21,7 +21,6 @@
> >
> > #include <spice/qxl_dev.h>
> >
> > -#include "red-common.h"
> > #include "memslot.h"
> >
> > typedef struct RedDrawable {
> > diff --git a/server/red-record-qxl.h b/server/red-record-qxl.h
> > index 7332afe..ed22bad 100644
> > --- a/server/red-record-qxl.h
> > +++ b/server/red-record-qxl.h
> > @@ -21,7 +21,6 @@
> >
> > #include <spice/qxl_dev.h>
> >
> > -#include "red-common.h"
> > #include "memslot.h"
> > #include "utils.h"
> >
> >
>
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel