[PATCH] Fix marshallers for SpiceMsgPortInit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Protocol states that name is an array of bytes but the marshallers are
considering it a pointer to an array of bytes. A client that does not
use demarshallers from spice-common will find an incorrect
implementation of spice-server SpiceMsgPortInit.

Reported-by: Oliver Gutierrez <ogutierrez@xxxxxxxxxx>
Signed-off-by: Pavel Grunt <pgrunt@xxxxxxxxxx>
Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx>
---
 spice.proto | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spice.proto b/spice.proto
index 0bfc515..08d7152 100644
--- a/spice.proto
+++ b/spice.proto
@@ -1412,7 +1412,7 @@ channel PortChannel : SpicevmcChannel {
  server:
     message {
 	uint32 name_size;
-	uint8 *name[name_size] @zero_terminated @marshall @nonnull;
+	uint8 name[name_size] @zero_terminated @marshall @nonnull;
 	uint8 opened;
     } init = 201;
     message {
-- 
2.7.4

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]