Re: [PATCH] Fixed syntax error. Debugger is not an object or command. It is a reserved word and DEBUG > 0 && syntax does not work with it

[Oliver Gutierrez <ogutierrez@xxxxxxxxxx>]

Ok. Thanks for the tips :D

On Thu, Sep 8, 2016 at 2:26 PM, Pavel Grunt <pgrunt@xxxxxxxxxx> wrote:

Ah, I didn't realized before pushing /o\

Please make the summary shorter - you can put the other sentence to
the commit body.

On Thu, 2016-09-08 at 13:21 +0200, Oliver Gutierrez wrote:
> ---
>  spiceconn.js | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/spiceconn.js b/spiceconn.js
> index 010a446..796f954 100644
> --- a/spiceconn.js
> +++ b/spiceconn.js
> @@ -189,8 +189,10 @@ SpiceConn.prototype =
>  
>                  if (msg.type > 500)
>                  {
> -                    DEBUG > 0 && alert("Something has gone very
> wrong; we think we have message of type " + msg.type);
> -                    DEBUG > 0 && debugger;
> +                    if (DEBUG > 0) {
Please align to our brackets & indentation style 
> +                      alert("Something has gone very wrong; we
> think we have message of type " + msg.type);
> +                      debugger;
> +                    }
>                  }
>  
>                  if (msg.size == 0)
Besides that it works & looks good to me

Thanks,
Pavel

--

Oliver Gutierrez
Associate Software Engineer - Desktop Management tools
Red Hat

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel