> > > > Based on a patch by Sandy Stutsman <sstutsma@xxxxxxxxxx> > > > > Signed-off-by: Sameeh Jubran <sameeh@xxxxxxxxxx> > > Hi, from > https://github.com/flexVDI/qxl-dod/commit/a21bc96bffdd2a298b1e7f86c380bfaabbcbe7cc > looks like the original author of this was Javier and not Sandy (contains > also > the original small typo). > > You should either change author back with "git commit --amend --author"... or > add a "Signed-off-by: Javier "... . > Found a even more ancient patch from Sandy, so Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx> I would however more this as 1/xx. Frediano > > --- > > qxldod/BaseObject.cpp | 11 +++++++++++ > > qxldod/BaseObject.h | 1 + > > 2 files changed, 12 insertions(+) > > > > diff --git a/qxldod/BaseObject.cpp b/qxldod/BaseObject.cpp > > index ac270fd..a93c040 100755 > > --- a/qxldod/BaseObject.cpp > > +++ b/qxldod/BaseObject.cpp > > @@ -70,3 +70,14 @@ void __cdecl operator delete[](void* pObject) > > ExFreePool(pObject); > > } > > } > > + > > +void __cdecl operator delete(void *pObject, size_t s) > > +{ > > + PAGED_CODE(); > > + > > + UNREFERENCED_PARAMETER(s); > > Looks quite C style, > > void __cdecl operator delete(void *pObject, size_t) > > could be the C++ style. Just a style by the way. > > > + > > + if (pObject != NULL) { > > + ExFreePool(pObject); > > + } > > +} > > diff --git a/qxldod/BaseObject.h b/qxldod/BaseObject.h > > index 66e66e4..94e7f8e 100755 > > --- a/qxldod/BaseObject.h > > +++ b/qxldod/BaseObject.h > > @@ -56,4 +56,5 @@ _When_((PoolType & NonPagedPoolMustSucceed) != 0, > > "Allocation failures cause a system crash")) > > void* __cdecl operator new[](size_t Size, POOL_TYPE PoolType = PagedPool); > > void __cdecl operator delete(void* pObject); > > +void __cdecl operator delete(void *pObject, size_t s); > > void __cdecl operator delete[](void* pObject); > > Beside authorship patch is fine. > > I would also put this as patch 1 so converting to new VS will > get proper delete code. > _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel