Re: [PATCH qxl-wddm-dod 16/26] Remove minimum size restrict for custom resolution.

[Sameeh Jubran <sameeh@xxxxxxxxxx>]

On Tue, Aug 30, 2016 at 6:24 PM, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote:

>
> From: Sandy Stutsman <sstutsma@xxxxxxxxxx>
>
> ---
>  qxldod/QxlDod.cpp | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> index 3139092..74cd259 100755
> --- a/qxldod/QxlDod.cpp
> +++ b/qxldod/QxlDod.cpp
> @@ -4488,11 +4488,10 @@ NTSTATUS
> QxlDevice::SetCustomDisplay(QXLEscapeSetCustomDisplay* custom_display)
>      UINT xres = custom_display->xres;
>      UINT yres = custom_display->yres;
>      UINT bpp = QXL_BPP;
> -    DbgPrint(TRACE_LEVEL_ERROR, ("%s - %d (%dx%d#%d)\n", __FUNCTION__, m_Id,
> xres, yres, bpp));
> +    DbgPrint(TRACE_LEVEL_WARNING, ("%s - %d (%dx%d#%d)\n", __FUNCTION__,
> m_Id, xres, yres, bpp));
>      if (xres < MIN_WIDTH_SIZE || yres < MIN_HEIGHT_SIZE) {
> -        DbgPrint(TRACE_LEVEL_VERBOSE, ("%s: (%dx%d#%d) must be at least
> (%dxd)\n", __FUNCTION__,
> +        DbgPrint(TRACE_LEVEL_VERBOSE, ("%s: (%dx%d#%d) less than (%dxd)\n",
> __FUNCTION__,
>              xres, yres, bpp, MIN_WIDTH_SIZE, MIN_HEIGHT_SIZE));
> -        return ERROR_INVALID_DATA;
>      }
>      m_CustomMode =(USHORT) ((m_CustomMode == m_ModeCount-1)?  m_ModeCount -
>      2 : m_ModeCount - 1);
>

I don't much agree with this patch.
I would prefer to reduce the size instead, something like 800x600 instead of
1024x768 if needed.

Can you please explain why? 

In the previous driver (XPDM) this is how it used to work, full arbitrary resolution with no minimal restriction at all.

Moreover Windows supports very low resolutions and thus such restriction shouldn't exist.

 

Frediano

--

Respectfully,

Sameeh Jubran

Linkedin

Junior Software Engineer @ Daynix.

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel