On Tue, Aug 30, 2016 at 07:01:48AM -0400, Marc-André Lureau wrote: > Hi > > ----- Original Message ----- > > On Fri, Aug 19, 2016 at 09:35:09PM +0400, marcandre.lureau@xxxxxxxxxx wrote: > > > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > > > > > So we can drop the AC_SUBST for _CFLAGS & _LIBS variable (since 0.24 > > > but there is no clean way to check that before PKG_PREREQ in 0.29, > > > released last year) > > > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > > --- > > > configure.ac | 26 ++++---------------------- > > > 1 file changed, 4 insertions(+), 22 deletions(-) > > > > > > diff --git a/configure.ac b/configure.ac > > > index 9b2351d..1e27202 100644 > > > --- a/configure.ac > > > +++ b/configure.ac > > > @@ -12,6 +12,8 @@ AM_INIT_AUTOMAKE([foreign dist-bzip2 -Wall -Werror > > > -Wno-portability]) > > > m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) > > > LT_INIT([disable-static win32-dll]) > > > AM_MAINTAINER_MODE > > > +m4_ifndef([PKG_PREREQ], > > > + [m4_fatal([must install pkg-config 0.29 or later before running > > > autoconf/autogen])]) > > > > NACK to that bit, as Victor's testing showed, it's not that widespread > > yet. Maybe something PKG_PREREQ-like can be built using $(pkg-config > > --version) and m4_version_compare(), alternatively, we could just assume 0.24 > > is always present. > > There is PKG_PROG_PKG_CONFIG, but as the doc states: > > Unlike PKG_PROG_PKG_CONFIG, which checks the user's > dnl installed version of pkg-config, this checks the developer's version > dnl of pkg.m4 when generating configure. > > Imho downstreams can ship a patch to remove the PREREQ if they don't have 0.29. Victor is not a downstream and hit some issues with that, so I expect this is going to cause pain here and there. pkg-config 0.29 is not widespread enough that we can force its use and just shrug and tell people to cope with it. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel