Re: [client v2 1/3] streaming: Modify display_update_stream_report() to take a SpiceChannel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 18 Aug 2016, Frediano Ziglio wrote:

> > 
> > This makes it consistent with the other channel-display functions.
> > 
> > Signed-off-by: Francois Gouget <fgouget@xxxxxxxxxxxxxxx>
> > ---
> > 
> > This patch makes sense on its own and can be applied even if the
> > other two in the series are not.
> > 
> > 
> 
> I prefer the actual version.

Why?

IMHO it makes no sense to cast a SpiceChannel* to a DisplayChannel* when 
calling display_update_stream_report() only to cast it back, twice, to a 
SpiceChannel* inside that function.


-- 
Francois Gouget <fgouget@xxxxxxxxxxxxxxx>
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]