On Thu, Aug 11, 2016 at 04:28:58PM +0200, Francois Gouget wrote: > > The following patch broke compilation of xf86-video-qxl: > > commit b41220b1441b8adea6db9a98e9da1b43a8f426bb > Author: Christophe Fergeau <cfergeau@xxxxxxxxxx> > Date: Thu Mar 5 15:28:22 2015 +0100 > > Mark unused public API methods/code as deprecated > > Acked-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> > > > The reason is it introduces a #include <glib.h> in spice-server.h which > is a *public* header! This means any application that needs to include > spice-server.h, like xf86-video-qxl, must now check for GLib even if > they don't use it, like xf86-video-qxl. They shouldn't have to check for it explicitly. The spice-server.pc pkgconfig file should have been updated in that commit so that glib-2.0 is listed under "Requires" instead of "Requires.private", then applications using spice-server would not have broken, as pkg-config would have just "done the right thing" and automatically added -I/path/to/glib/headers. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel