Re: [PATCH] Adding new ioctl for updating Vdagent state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 9 Aug 2016, at 16:03 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:

Hey,

On Tue, Aug 09, 2016 at 03:22:52PM +0300, Dmitry Fleytman wrote:

On 9 Aug 2016, at 14:23 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:

On Tue, Aug 09, 2016 at 09:22:15AM +0300, Sameeh Jubran wrote:
Hi,

What do you think that needs to be done?
The patches should be applied?
The interface of the device should be extended to support broadcasting the
mouse mode to the driver? ( I think would require to modify the spice
protocol )
The interface of spice-gtk should be extended to support broadcasting the
mouse mode to vdagent?

The filtering of cursor commands depending on server/mouse mode is
already done in spice-server in
https://cgit.freedesktop.org/spice/spice/tree/server/cursor-channel.c#n438
so I don't think we need to know too much about client/server mode in
the guest driver. Maybe some VGA/QXL distinction will be needed to avoid
some VGA-specific issues, but when using QXL, removing EnablePointer()
altogether should do the right thing both in client and server mode (did
not test).

Hi Christophe,

For some reason mouse movements are less smooth when we do not filter out mouse events on driver level.
I suspect this was the reason Sandy changed EnablePointer() behaviour of the driver.

Do you have any idea why could this happen?

Nope no idea, maybe too many events get sent? Adding the new ioctl
while asking me this question at the same time sounds like we are just
papering over an issue we don't understand.

Our investigation shows that this happens due to too many events indeed.
I thought, perhaps you have seen similar issues on other platforms (pre-win10/linux)
and have additional information.

Do you notice this "smoothness" issue with legacy qxl-win or on linux?
Is this in server on client mouse mode?

Christophe

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]