Re: [client 2/2 v2] streaming: Don't crash if the stream creation fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



For reference the crash happened in display_handle_stream_data() when 
calling trying to queue the frame because video_decoder is NULL (same 
sort of issue as on the server with video_encoder).

    st->video_decoder->queue_frame(st->video_decoder, in, latency)

But if not there the call would happen in 
display_session_mm_time_reset_cb() when calling rescheduling frames:

        st->video_decoder->reschedule(st->video_decoder);

So it's simpler to just not create the stream object if we cannot create 
the corresponding video decoder.


Note that currently create_gstreamer_decoder() would only fail if 
gstvideo_init() fails but I'm looking at moving the create_pipeline() 
call there so it only returns non-NULL if that succeeded.


-- 
Francois Gouget <fgouget@xxxxxxxxxxxxxxx>
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]