Hey, On Wed, Jul 27, 2016 at 04:34:18AM +0200, Fabiano Fidêncio wrote: > This bogus code was introduced when switching to GTask API. Seems that > while writing those patches I just overlooked this part and set the wrong > result for the task. As part of the problems introduced (and now fixed) > you can notice that no output stream was being sent to the guest. > > Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx> > --- > src/vmcstream.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/vmcstream.c b/src/vmcstream.c > index c536f71..7c7af44 100644 > --- a/src/vmcstream.c > +++ b/src/vmcstream.c > @@ -411,7 +411,7 @@ write_cb(GObject *source_object, > { > GTask *task = user_data; > > - g_task_return_pointer(task, g_object_ref(task), g_object_unref); > + g_task_return_pointer(task, res, NULL); Good catch! I'd take a ref on 'res' though as it's getting to get destroyed as soon as write_cb returns, and you don't know for sure whether g_task_return_pointer() is going to run in an idle or not, you don't know if the callback is going to call _finish() right away, ... So it feels safer overall to take a reference on 'res' as we need it to stay alive. Reviewed-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel