Re: [spice-gtk v3 4/4] usb-device-manager: Avoid USB event thread leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 01, 2016 at 04:19:00PM +0200, Hans de Goede wrote:
> > Proposed change to squash in this patch:
> > 
> > 
> > diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
> > index 806af74..aa48a01 100644
> > --- a/src/usb-device-manager.c
> > +++ b/src/usb-device-manager.c
> > @@ -390,7 +391,8 @@ static void spice_usb_device_manager_dispose(GObject *gobject)
> >          priv->hp_handle = 0;
> >      }
> >  #endif
> > -    if (priv->event_thread && !g_atomic_int_get(&priv->event_thread_run)) {
> > +    if (priv->event_thread) {
> > +        g_warn_if_fail(g_atomic_int_get(&priv->event_thread_run) == FALSE);
> >          g_thread_join(priv->event_thread);
> >          priv->event_thread = NULL;
> >      }
> 
> Yeah that is probably the best we can do.
> 
> So with this squashed in the entire series is:
> 
> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Thanks, pushed everything now!

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]