Re: [spice-gtk 2/3] usbredir: Use atomic for UsbDeviceManager::event_thread_run

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 29, 2016 at 12:07:48PM -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > This variable is accessed from 2 different threads (main thread and USB
> > event thread), so some care must be taken to read/write it.
> > ---
> 
> event_thread_run is a bool, you should make it a gint, probably even volatile.

I've changed it to gint in v2, I don't know about the volatile, are
there cases where not having it as a volatile is going to cause issues?
Code using GAtomic in glib does not seem to be using volatile.

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]