Re: [NSIS 5/5] ovirt: Add ovirt-guest-agent service removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Jun 22, 2016, at 10:54 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:

On Tue, Jun 21, 2016 at 07:35:14PM +0200, Vinzenz Feenstra wrote:

On Jun 21, 2016, at 5:11 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:


On Tue, Jun 21, 2016 at 05:26:33PM +0300, Yedidyah Bar David wrote:
From: Vinzenz Feenstra <vfeenstr@xxxxxxxxxx>

Previously the ovirt guest agent service registration has not been
removed during the uninstallation.
This patch adds the removal code.

Isn't this supposed to be handled by un.StopServices?
It has:

!ifdef OVIRT
push "OVirtGuestService"
Call ${un}StopService
!endif


Christophe

Thats stopping them, but not uninstalling (removing)

Ah right. The vdagent and balloon service would have the same issue
then, don't they? If yes, we could have a generic UninstallService
used for these various services.

Didn’t pay attention to those, I will have a look 


Christophe

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]