Re: [PATCH spice-gtk] widget: fix keyboard ungrab after click

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 20, 2016 at 5:34 PM, Marc-André Lureau
<marcandre.lureau@xxxxxxxxx> wrote:
> Hi
>
> On Mon, Jun 20, 2016 at 5:33 PM, Marc-André Lureau
> <marcandre.lureau@xxxxxxxxx> wrote:
>> On Mon, Jun 20, 2016 at 5:28 PM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote:
>>>>      gtk_widget_set_can_focus(widget, true);
>>>> +    gtk_event_box_set_above_child(GTK_EVENT_BOX(widget), true);
>>>
>>> I'd just do: s/true/TRUE before pushing, but no need to resend the
>>> patch because of this is just my preference :-)
>>
>> The line above uses lowercase 'true', I guess I'll change it too then ;)
>>
>
> Oh well, 'true' seems to win anyway:
> elmarco@anjohibe:~/src/spice/spice-gtk (master *%)$ git grep -c TRUE
> src/spice-widget.c
> src/spice-widget.c:17
> elmarco@anjohibe:~/src/spice/spice-gtk (master *%)$ git grep -c true
> src/spice-widget.c
> src/spice-widget.c:38
>
>
> --
> Marc-André Lureau

So, keep it as it is.
Feel free to push the patch, Marc-André.

-- 
Fabiano Fidêncio
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]