On 06/15/2016 02:45 PM, Eduardo Lima (Etrunko) wrote:
> Introduced by commit 903c91cd3013c763abd3f2292f8fbd911a0c83f0, this
> variable is used only for LZ4 code. Move the declaration to the proper
> block of code.
>
> Build log:
>
> spicevmc.c: In function 'handle_compressed_msg':
> spicevmc.c:346:14: error: variable 'decompressed' set but not used [-Werror=unused-but-set-variable]
> uint8_t *decompressed;
> ^
>
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx>
> ---
> server/spicevmc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/server/spicevmc.c b/server/spicevmc.c
> index e949827..ea74888 100644
> --- a/server/spicevmc.c
> +++ b/server/spicevmc.c
> @@ -345,7 +345,6 @@ static int handle_compressed_msg(SpiceVmcState *state, RedChannelClient *rcc,
> {
> /* NOTE: *decompressed is free by the char-device */
> int decompressed_size;
> - uint8_t *decompressed;
> RedCharDeviceWriteBuffer *write_buf;
>
> write_buf = red_char_device_write_buffer_get(state->chardev, rcc->client,
> @@ -353,11 +352,11 @@ static int handle_compressed_msg(SpiceVmcState *state, RedChannelClient *rcc,
> if (!write_buf) {
> return FALSE;
> }
> - decompressed = write_buf->buf;
>
> switch (compressed_data_msg->type) {
> #ifdef USE_LZ4
> case SPICE_DATA_COMPRESSION_TYPE_LZ4:
> + uint8_t *decompressed = write_buf->buf;
> decompressed_size = LZ4_decompress_safe ((char *)compressed_data_msg->compressed_data,
> (char *)decompressed,
> compressed_data_msg->compressed_size,
>
I found that this patch is broken, due to missing curly braces. I'll
have a new version posted.
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko@xxxxxxxxxx
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel