On Mon, 2016-06-06 at 04:21 -0400, Frediano Ziglio wrote:
> >
> >
> > On Fri, 2016-06-03 at 10:59 +0100, Frediano Ziglio wrote:
> > >
> > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> > > ---
> > > server/red-worker.c | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/server/red-worker.c b/server/red-worker.c
> > > index a14f55d..e754bd2 100644
> > > --- a/server/red-worker.c
> > > +++ b/server/red-worker.c
> > > @@ -156,6 +156,11 @@ static int red_process_cursor(RedWorker *worker, int
> > > *ring_is_empty)
> > > worker->cursor_poll_tries++;
> > > return n;
> > > }
> > > +
> > > + if (worker->record)
> > > + red_record_qxl_command(worker->record, &worker->mem_slots,
> > > ext_cmd,
> > > + stat_now(CLOCK_MONOTONIC));
> > > +
> > consider using spice_get_monotonic_time_ns() instead?
> >
> This is symmetric to the code in red_process_display.
> Should not be red_get_monotonic_time_ns() ?
They do the same thing, but I think that using the helper is better than using
stat_now(). As for the name, probably red_ is better than spice_ since internal
stuff uses the Red/red_ prefix by convention.
>
> >
> > >
> > > worker->cursor_poll_tries = 0;
> > > switch (ext_cmd.cmd.type) {
> > > case QXL_CMD_CURSOR: {
> >
> > Acked-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
> >
> >
> Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel