Re: [PATCH 1/3] Fix some typos in comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>


On Tue, 2016-05-31 at 10:53 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
>  server/char-device.h | 4 ++--
>  server/reds.c        | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/server/char-device.h b/server/char-device.h
> index 39bff4e..2dd848f 100644
> --- a/server/char-device.h
> +++ b/server/char-device.h
> @@ -175,9 +175,9 @@ int red_char_device_restore(RedCharDevice *dev,
>   * This routine is a workaround for a bad tokens management in the vdagent
>   * protocol:
>   *  The client tokens' are set only once, when the main channel is
> initialized.
> - *  Instead, it would have been more appropriate to reset them upon
> AGEN_CONNECT.
> + *  Instead, it would have been more appropriate to reset them upon
> AGENT_CONNECT.
>   *  The client tokens are tracked as part of the RedCharDeviceClient. Thus,
> - *  in order to be backwartd compatible with the client, we need to track the
> tokens
> + *  in order to be backward compatible with the client, we need to track the
> tokens
>   *  event when the agent is detached. We don't destroy the char_device state,
> and
>   *  instead we just reset it.
>   *  In addition, there is a misshandling of AGENT_TOKENS message in spice-
> gtk: it
> diff --git a/server/reds.c b/server/reds.c
> index 74deb58..9367a6d 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -546,7 +546,7 @@ static void reds_reset_vdp(RedsState *reds)
>      /* resetting and not destroying the dev as a workaround for a bad
>       * tokens management in the vdagent protocol:
>       *  The client tokens' are set only once, when the main channel is
> initialized.
> -     *  Instead, it would have been more appropriate to reset them upon
> AGEN_CONNECT.
> +     *  Instead, it would have been more appropriate to reset them upon
> AGENT_CONNECT.
>       *  The client tokens are tracked as part of the RedCharDeviceClient.
> Thus,
>       *  in order to be backward compatible with the client, we need to track
> the tokens
>       *  even if the agent is detached. We don't destroy the char_device, and
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]