Hi ----- Original Message ----- > Hi Marc-André, > > On Mon, 2016-05-30 at 11:54 -0400, Marc-André Lureau wrote: > > Hi > > > > ----- Original Message ----- > > > Related: rhbz#1335239 > > > > include header, but what for? > > It should be included otherwise changing a declaration in spice-uri-priv.h > will > not require changing the corresponding definition in spice-uri.c. Ah that makes sense now, please describe the reason in commit message too. Forgot we had -Wmissing-prototypes... > > > Shouldn't it be merged with some other patch? > > Currently there is no issue. I would rather drop it than merging it to an > unrelated patch. > > Pavel > > > > > > --- > > > src/spice-uri.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/src/spice-uri.c b/src/spice-uri.c > > > index 8cf870d..3bdb502 100644 > > > --- a/src/spice-uri.c > > > +++ b/src/spice-uri.c > > > @@ -22,6 +22,7 @@ > > > > > > #include "spice-client.h" > > > #include "spice-uri.h" > > > +#include "spice-uri-priv.h" > > > > > > /** > > > * SECTION:spice-uri > > > -- > > > 2.8.3 > > > > > > _______________________________________________ > > > Spice-devel mailing list > > > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > > > https://lists.freedesktop.org/mailman/listinfo/spice-devel > > > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel > _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel