Re: [PATCH v2 2/2] fix crash if agent interface is removed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Hey,
> 
> On Mon, May 09, 2016 at 10:03:03AM +0100, Frediano Ziglio wrote:
> > Removing an interface cause SpiceBaseInstance->st to be set to NULL.
> > This pointer was then deferenced in agent code.
> > As SpiceBaseInstance should not be used after this call make sure
> > we don't keep pointers to it.
> 
> I guess it cannot hurt... However, it would be a good time to document
> how we expect char_device_attach/remove to behave wrt to the lifetime of
> the various instances we have (char device, sin, vdagent, ...).
> 
> Christophe
> 

Do you have any suggestion on where to document this?
Do you think this is a stopover for the patch?
Do you think the fix should be done in another way?

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]