Visarion, On Wed, May 4, 2016 at 5:19 PM, Alexandru Visarion <viorel.visarion@xxxxxxxxx> wrote: > From: Visarion-Mingopol Alexandru <viorel.visarion@xxxxxxxxx> > > There is no reason to not include the spice_get_option_group > method in the generated bindings, as it can be useful. > > It was removed in the commit 2db9b8dd037e22d2b04e8e2aeecfd685524b7fef, > for the reason of causing warnings, but no warnings show up now. > --- > src/spice-option.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/spice-option.c b/src/spice-option.c > index 46ae530..7a17150 100644 > --- a/src/spice-option.c > +++ b/src/spice-option.c > @@ -177,7 +177,7 @@ static gboolean parse_preferred_compression(const gchar *option_name, const gcha > } > > /** > - * spice_get_option_group: (skip) > + * spice_get_option_group: > * > * Gets commandline options. > * > -- > 2.5.5 > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel If you agree, I would like to change the short log to: "doc,gir: Don't skip spice_get_option_group()" Let me know if you agree that I can do the change before pushing (and you don't need to submit a v3). Acked-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx> Best Regards, -- Fabiano Fidêncio _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel