On Tue, 3 May 2016, Christophe Fergeau wrote:
[...]
> > I think it's useful to be able to print the name of the GStreamer
> > encoder, particularly for this warning:
> >
> > spice_warning("GStreamer error: could not find the %s bitrate parameter", gstenc_name);
>
> Ah, for sure, I was not suggesting totally removing the helper, just not
> using it in create_pipeline() since there is already a switch
> (codec_type) there anyway. I knew my comment was not clear :(
I think it's more important not to duplicate the code that selects which
GStreamer encoder to use. If the two places got out of sync it would be
worse than not havign the name in the error message.
--
Francois Gouget <fgouget@xxxxxxxxxxxxxxx>
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel