Re: [PATCH] Make asciidoc a hard requirement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/03/2016 06:08 AM, Uri Lublin wrote:
> On 05/02/2016 03:32 PM, Eduardo Lima (Etrunko) wrote:
>> On 05/02/2016 07:39 AM, Uri Lublin wrote:
>>> On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote:
>>>> The problem happens when you run 'make dist' in a system without
>>>> asciidoc installed. Even though in configure time there is a check for
>>>> building the manual, it is required to be built for distribution.
>>>
>>> Hi,
>>>
>>> I think we should not force building the manual nor require asciidoc
>>> to build spice-server.
>>>
>>
>> I disagree. The output of make dist should be the same no matter what
>> system the command is run. Users should have the required dependencies
>> installed if they are interested in building spice-server from the
>> source code tarball.
>>
>>> We better find another way to make 'make dist' work
>>>
>>> Regards,
>>>     Uri.
>>>
>>
>> The only other option I see is to keep track of the generated files in
>> git, and if there is any modifications, generate it again manually.
> 
> For example, one can configure --enable-manual before running make dist.
> 
> Or install asciidoc before running configure.
> 

Sure, but the idea is exactly to avoid those extra additional steps for
specific cases. Is it really too much to ask for another build dependency?

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko@xxxxxxxxxx
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]