Ahh, I see you removed this check here. In my opinion, if we do use dbus-1 for both backends, this could be squashed into the previous commit. However, I'm still interested in your thoughts about using gdbus. Reviewed-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> On Sat, 2016-04-23 at 12:53 +0200, Victor Toso wrote: > Previous patch makes the agent depend on dbus-1 so we don't need to do extra > check on console-kit. > --- > configure.ac | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git a/configure.ac b/configure.ac > index aa2ef9f..fc5943b 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -108,19 +108,9 @@ fi > AM_CONDITIONAL(HAVE_LIBSYSTEMD_LOGIN, test x"$have_libsystemd_login" = > "xyes") > > if test "$with_session_info" = "auto" || test "$with_session_info" = "console > -kit"; then > - PKG_CHECK_MODULES([DBUS], > - [dbus-1], > - [have_console_kit="yes"], > - [have_console_kit="no"]) > - if test x"$have_console_kit" = "xno" && test "$with_session_info" = > "console-kit"; then > - AC_MSG_ERROR([console-kit support explicitly requested, but some > required packages are not available]) > - fi > - if test x"$have_console_kit" = "xyes"; then > - AC_DEFINE([HAVE_CONSOLE_KIT], [1], [If defined, vdagentd will be > compiled with ConsoleKit support]) > - with_session_info="console-kit" > - else > - with_session_info="none" > - fi > + AC_DEFINE([HAVE_CONSOLE_KIT], [1], [If defined, vdagentd will be compiled > with ConsoleKit support]) > + have_console_kit="yes" > + with_session_info="console-kit" > else > have_console_kit="no" > fi _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel