Re: [PATCH server] coverity: avoid resource leak (82248)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> free data(SpiceChunks) in case of an error
> ---
>  server/red-parse-qxl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c
> index 18b7ea6..915056a 100644
> --- a/server/red-parse-qxl.c
> +++ b/server/red-parse-qxl.c
> @@ -378,6 +378,7 @@ static SpiceChunks
> *red_get_image_data_flat(RedMemSlotInfo *slots, int group_id,
>      data->data_size      = size;
>      data->chunk[0].data  = (void*)memslot_get_virt(slots, addr, size,
>      group_id, &error);
>      if (error) {
> +        free(data);
>          return 0;
>      }
>      data->chunk[0].len   = size;

Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx>

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]