These function are called on both side of dispatcher so the increment/decrement of the counter is done in multiple thread. This fix https://bugzilla.redhat.com/show_bug.cgi?id=1253375. Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> --- server/red-channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index d8f1d27..cfddea0 100644 --- a/server/red-channel.c +++ b/server/red-channel.c @@ -2064,13 +2064,13 @@ RedClient *red_client_new(RedsState *reds, int migrated) RedClient *red_client_ref(RedClient *client) { spice_assert(client); - client->refs++; + g_atomic_int_inc(&client->refs); return client; } RedClient *red_client_unref(RedClient *client) { - if (!--client->refs) { + if (g_atomic_int_dec_and_test(&client->refs)) { spice_debug("release client=%p", client); pthread_mutex_destroy(&client->lock); free(client); -- 2.5.5 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel