Re: [spice-common 2/8] coverity: avoid resource leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 04, 2016 at 10:03:33AM +0200, Fabiano Fidêncio wrote:
> ---
>  common/canvas_base.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/common/canvas_base.c b/common/canvas_base.c
> index fa4d373..650422b 100644
> --- a/common/canvas_base.c
> +++ b/common/canvas_base.c
> @@ -769,6 +769,7 @@ static inline SpicePalette *canvas_get_localized_palette(CanvasBase *canvas, Spi
>      case SPICE_SURFACE_FMT_16_565:
>      default:
>          spice_warn_if_reached();
> +        free(copy);
>          return NULL;

One could argue that after a spice_warn_if_reached() all bets are off
(ie programming error), but here it's easy to at least avoid the leak

Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]