On Thu, Mar 24, 2016 at 02:19:22PM +0000, Frediano Ziglio wrote: > CursorChannel and DisplayChannel was initialized half in red_worker_new > and half in red_dispatcher_init using some accessor for RedWorker > (red_worker_get_cursor_channel and red_worker_get_display_channel). > Moving directly into red_worker_new make easier to follow code path. To me, the generation of 'payload' data and the call to dispatcher_send_message() belongs in dispatcher implementations, ie red-qxl.c. Before this commit: $ git grep -l dispatcher_send_message server/dispatcher.c server/dispatcher.h server/main-dispatcher.c server/red-qxl.c so this commit would move some of these to red-worker.c. Imo this is a move in the wrong direction. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel