Re: [qxl 5/5] spiceqxl_audio: Stop the playback channel if there is nothing to play

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Francois,

> @@ -361,14 +366,23 @@ static void start_watching(qxl_screen_t *qxl)
>      }
>  }
>  
> +/* a helper for read_from_fifos() */
>  static void wall_ticker(void *opaque)
>  {
>      qxl_screen_t *qxl = opaque;
>      struct audio_data *data = qxl->playback_opaque;
>  
> -    data->wall_timer_live = 0;
> -
> -    read_from_fifos(-1, 0, qxl);
> +    if (data->wall_timer_type == IDLE_MS) {
> +        /* There is no open fifo anymore */

I think this comment is not necessarily correct.  The fifos could still
be open, just not producing audio data, right?

Cheers,

Jeremy
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]