On Thu, 3 Mar 2016, Christophe Fergeau wrote: [...] > > +static SpiceGstVideoBuffer* create_gst_video_buffer(void) > > +{ > > + SpiceGstVideoBuffer *buffer = spice_new0(SpiceGstVideoBuffer, 1); > > + buffer->base.free = &gst_video_buffer_free; > > + return buffer; > > I forgot to mention that we usually don't use & for function pointers, > just direct assignment. I've noticed it in a few places in this patch. I removed them from the patch series. -- Francois Gouget <fgouget@xxxxxxxxxxxxxxx> _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel