Re: [PATCH libcacard 1/2] nss: report error on invalid db= argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ACK series.

On Thu, Mar 03, 2016 at 01:58:16AM +0100, Marc-André Lureau wrote:
> The db argument must end with " or \n.
> 
> Found thanks to clang scan-build.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> Reported-by: Miroslav Rezanina <mrezanin@xxxxxxxxxx>
> ---
>  src/vcard_emul_nss.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/vcard_emul_nss.c b/src/vcard_emul_nss.c
> index 08a60c6..156a916 100644
> --- a/src/vcard_emul_nss.c
> +++ b/src/vcard_emul_nss.c
> @@ -1266,6 +1266,10 @@ vcard_emul_options(const char *args)
>              args++;
>              db = args;
>              args = strpbrk(args, "\"\n");
> +            if (args == NULL) {
> +              fprintf(stderr, "Error: invalid db argument.\n");
> +              return NULL;
> +            }
>              opts->nss_db = g_strndup(db, args-db);
>              if (*args != 0) {
>                  args++;
> -- 
> 2.5.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]