This causes:
make[4]: Entering directory '/home/teuf/redhat/spice/server'
CC dcc.lo
dcc.c: In function 'dcc_compress_image_jpeg':
dcc.c:852:26: error: variable 'jpeg_in_type' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
JpegEncoderImageType jpeg_in_type;
^
dcc.c:854:9: error: variable 'has_alpha' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
int has_alpha = FALSE;
^
dcc.c: In function 'dcc_compress_image_quic.isra.10':
dcc.c:1020:19: error: variable 'type' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
QuicImageType type;
^
not sure why...
Christophe
On Thu, Feb 11, 2016 at 02:38:45PM -0600, Jonathon Jongsma wrote:
> Acked-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
>
>
>
> On Tue, 2016-02-09 at 10:28 +0000, Frediano Ziglio wrote:
> > These automatic variable are used just inside the function.
> >
> > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> > ---
> > server/dcc.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/server/dcc.c b/server/dcc.c
> > index 99aadf0..4f458ec 100644
> > --- a/server/dcc.c
> > +++ b/server/dcc.c
> > @@ -792,9 +792,9 @@ static int dcc_compress_image_jpeg(DisplayChannelClient
> > *dcc, SpiceImage *dest,
> > LzData *lz_data = &dcc->lz_data;
> > JpegEncoderContext *jpeg = dcc->jpeg;
> > LzContext *lz = dcc->lz;
> > - volatile JpegEncoderImageType jpeg_in_type;
> > + JpegEncoderImageType jpeg_in_type;
> > int jpeg_size = 0;
> > - volatile int has_alpha = FALSE;
> > + int has_alpha = FALSE;
> > int alpha_lz_size = 0;
> > int comp_head_filled;
> > int comp_head_left;
> > @@ -960,7 +960,7 @@ static int dcc_compress_image_quic(DisplayChannelClient
> > *dcc, SpiceImage *dest,
> > {
> > QuicData *quic_data = &dcc->quic_data;
> > QuicContext *quic = dcc->quic;
> > - volatile QuicImageType type;
> > + QuicImageType type;
> > int size, stride;
> > stat_start_time_t start_time;
> > stat_start_time_init(&start_time, &DCC_TO_DC(dcc)->quic_stat);
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel