On Fri, 2016-01-29 at 10:53 +0000, Frediano Ziglio wrote:
> The req_cmd_notification callback is called by spice-server when it
> has processed all commands and wants to be notified (by a wakeup) that
> new commands has been appended to the command queue.
s/has/have/
> Replay utility try to fill the commands when it detects spice-server
> is trying to read commands but there are no more commands.
"The replay utility tries to fill..."
"... detects that spice-server..."
> However the append of new commands happen in a separate thread so if
"However, new commands are appended in a separate thread, so if..."
> the main red worker loop on spice-server is really tight this request
> can happen.
> Avoid to print any message on this condition, message will be appended
"avoid printing any message..."
> and loop waked up when replay code can do it.
s/waked/woken/
>
> Signed-by: Frediano Ziglio <figlio@xxxxxxxxxx>
> ---
> server/tests/replay.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/server/tests/replay.c b/server/tests/replay.c
> index c7f3f00..87b4a98 100644
> --- a/server/tests/replay.c
> +++ b/server/tests/replay.c
> @@ -186,9 +186,6 @@ static int req_cmd_notification(QXLInstance *qin)
> if (!started)
> return TRUE;
This initial branch doesn't seem needed anymore if we're just returning TRUE in
both circumstances.
>
> - g_printerr("id: %d, queue length: %d",
> - g_source_get_id(fill_source),
> g_async_queue_length(aqueue));
> -
> return TRUE;
> }
>
Reviewed-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel