----- Original Message ----- > From: "Christophe Fergeau" <cfergeau@xxxxxxxxxx> > To: "Frediano Ziglio" <fziglio@xxxxxxxxxx> > Cc: spice-devel@xxxxxxxxxxxxxxxxxxxxx > Sent: Thursday, January 28, 2016 2:55:04 PM > Subject: Re: [PATCH] tests: exit on SIGABRT > > Hey, > > On Thu, Jan 28, 2016 at 02:22:22PM +0000, Frediano Ziglio wrote: > > Fatal error exit usually with abort() causing SIGABRT to be triggered > > which can have problems with core dump degeration depending on system > > degeration? generation? > Yes, sorry, was a typo. > > settings. Capturing and exiting on this signal solve the problem. > > I find it quite surprising that core dump generation can prevent the > test cases from working, and that we need to add one layer of SIGABRT > interception to get things working :( > > Christophe > The problem is that there is too much possible settings for core generation (ehmm degeration :) ). Frediano > > > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > > --- > > tests/test-logging.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/tests/test-logging.c b/tests/test-logging.c > > index 008ce48..dad7a60 100644 > > --- a/tests/test-logging.c > > +++ b/tests/test-logging.c > > @@ -376,11 +376,17 @@ static void test_spice_g_messages_debug_all(void) > > g_test_trap_assert_stderr("*g_message\n*other_message\n"); > > } > > > > +static void handle_sigabrt(int sig) > > +{ > > + _exit(1); > > +} > > > > int main(int argc, char **argv) > > { > > GLogLevelFlags fatal_mask; > > > > + signal(SIGABRT, handle_sigabrt); > > + > > fatal_mask = (GLogLevelFlags)g_log_set_always_fatal((GLogLevelFlags) > > G_LOG_FATAL_MASK); > > > > g_test_init(&argc, &argv, NULL); > > -- > > 2.4.3 > > > > _______________________________________________ > > Spice-devel mailing list > > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > > http://lists.freedesktop.org/mailman/listinfo/spice-devel > _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel