Re: [PATCH spice-common] Use lz4 if possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
On Wed, Jan 20, 2016 at 09:02:30AM +0100, Pavel Grunt wrote:
> Change the default option to "auto"
I really don't see any problem on having this
Acked-by: Victor Toso <victortoso@xxxxxxxxxx>

> ---
>  m4/spice-deps.m4 | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
> index d533c81..88edf7e 100644
> --- a/m4/spice-deps.m4
> +++ b/m4/spice-deps.m4
> @@ -207,14 +207,20 @@ AC_DEFUN([SPICE_CHECK_PYTHON_MODULES], [
>  # ---------------
>  AC_DEFUN([SPICE_CHECK_LZ4], [
>      AC_ARG_ENABLE([lz4],
> -      AS_HELP_STRING([--enable-lz4=@<:@yes/no@:>@],
> -                     [Enable LZ4 compression support @<:@default=no@:>@]),
> +      AS_HELP_STRING([--enable-lz4=@<:@yes/no/auto@:>@],
> +                     [Enable LZ4 compression support @<:@default=auto@:>@]),
>        [],
> -      [enable_lz4="no"])
> +      [enable_lz4="auto"])
>  
>      if test "x$enable_lz4" != "xno"; then
> -      PKG_CHECK_MODULES([LZ4], [liblz4])
> -      AC_DEFINE(USE_LZ4, [1], [Define to build with lz4 support])
> +      PKG_CHECK_MODULES([LZ4], [liblz4],
> +        [enable_lz4=yes
> +         AC_DEFINE(USE_LZ4, [1], [Define to build with lz4 support])
> +        ],
> +        [if test "x$enable_lz4" = "xyes"; then
> +          AC_MSG_ERROR([lz4 support requested but liblz4 could not be found])
> +        fi]
> +      )
>      fi
>  ])
>  
> -- 
> 2.5.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]