Re: [PATCH server v2 11/13] Send current GL scanout to new client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Fri, Jan 22, 2016 at 4:15 PM, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote:
> That's because all display state is mainly in DisplayChannel (like monitors_config).
> This patch make clear that DisplayChannel has to know RedWorker which has to know
> QXL.
> You will note that calls to red_worker_get_qxl are really limited. They should be
> removed. You added 4 calls.

If you can stream (through the dispatcher) all the state to the
display channel this is reasonable.

However, the point here is to have a shared state (the scanout), up to date..

> I think would be better if  spice_gl_scanout call a function that make DisplayChannel
> do the change for you.

You can't reach the display-channel from QXLInstance without the
dispatcher (which would be less efficient and not easily atomic) or
resorting to ugly hacks: it's simpler to keep the current scanout
state on the QXLInstance.

-- 
Marc-André Lureau
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]