Re: [spice-common v4 6/7] log: Kill spice_warn_if

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> It's redundant with spice_warn_if_fail(), and can even be confusing.
> 
> Acked-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>

Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx>

Frediano


> ---
>  common/log.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/common/log.h b/common/log.h
> index a56105a..0e03f59 100644
> --- a/common/log.h
> +++ b/common/log.h
> @@ -95,12 +95,6 @@ void spice_log(const char *log_domain,
>      }                                                   \
>  } G_STMT_END
>  
> -#define spice_warn_if(x) G_STMT_START {                 \
> -    if G_UNLIKELY(x) {                                  \
> -        spice_warning("condition `%s' reached", #x);    \
> -    }                                                   \
> -} G_STMT_END
> -
>  #define spice_assert(x) G_STMT_START {                  \
>      if G_LIKELY(x) { } else {                           \
>          spice_error("assertion `%s' failed", #x);       \
> --
> 2.5.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]