On Wed, Jan 20, 2016 at 01:38:52PM +0100, Fabiano Fidêncio wrote:
> On Mon, Jan 18, 2016 at 11:31 AM, Christophe Fergeau
> <cfergeau@xxxxxxxxxx> wrote:
> > On Mon, Jan 18, 2016 at 10:05:38AM +0100, Fabiano Fidêncio wrote:
> >> @@ -1794,15 +1785,15 @@ static void file_xfer_close_cb(GObject *object,
> >>
> >> /* Notify to user that files have been transferred or something error
> >> happened. */
> >> - res = g_simple_async_result_new(G_OBJECT(self->priv->channel),
> >> - self->priv->callback,
> >> - self->priv->user_data,
> >> - spice_main_file_copy_async);
> >> + task = g_task_new(self->priv->channel,
> >> + self->priv->cancellable,
> >> + self->priv->callback,
> >> + self->priv->user_data);
> >> if (self->priv->error) {
> >> - g_simple_async_result_take_error(res, self->priv->error);
> >> - g_simple_async_result_set_op_res_gboolean(res, FALSE);
> >> + g_task_return_error(task, self->priv->error);
> >> + g_task_return_boolean(task, FALSE);
> >
> > Not sure what GTask behaviour will be if you queue these 2 calls. Just
> > calling g_task_return_error() is going to be enough as
> > g_task_propagate_boolean() returns FALSE when an error is set.
>
> Hmm. It shouldn't be in this way. I missed this part :-\
> So, I do believe that in case of explicit errors we can call
> g_task_return_boolean() instead of g_task_return_error() (as I did
> with the other situations similar to this one).
>
> Is okay for you if I do the same here?
I would do
if (self->priv->error) {
- g_simple_async_result_take_error(res, self->priv->error);
- g_simple_async_result_set_op_res_gboolean(res, FALSE);
+ g_task_return_error(task, self->priv->error);
it seems you are suggesting keeping the other one?
(g_task_return_boolean).
Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel