> > In general, I appreciate a bit more justification in the commit log so I can > quickly understand the "why" in addition to the "what". In this case, I > assume > it's to reduce build time and avoid compiling these files twice. ACK with a > slightly expanded commit log. > > Acked-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> > > Actually I wrote that variable not only to include these files but to make sure they don't have other dependencies. However without any comment I think Marc idea was really good. The test is doing what is supposed to do and the Makefile is easier to read and aligned with other tests. So I'll Nack the patch and write a proper comment on the variable. Frediano > > On Thu, 2016-01-14 at 22:01 +0100, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxx> > > --- > > server/tests/Makefile.am | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am > > index 8caff04..15196f9 100644 > > --- a/server/tests/Makefile.am > > +++ b/server/tests/Makefile.am > > @@ -91,8 +91,4 @@ libstat_test3_a_CPPFLAGS = $(AM_CPPFLAGS) > > -DTEST_COMPRESS_STAT=1 -DTEST_RED_WORK > > libstat_test4_a_SOURCES = stat-test.c > > libstat_test4_a_CPPFLAGS = $(AM_CPPFLAGS) -DTEST_COMPRESS_STAT=1 > > -DTEST_RED_WORKER_STAT=1 -DTEST_NAME=stat_test4 > > > > -test_qxl_parsing_SOURCES = \ > > - test-qxl-parsing.c \ > > - ../red-parse-qxl.c \ > > - ../memslot.c \ > > - $(NULL) > > +test_qxl_parsing_LDADD = ../libserver.la $(LDADD) _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel