> Subject: [PATCH server v2 03/13] tests: make sure all tests are built on default rule > > We should have all or none, I don't see the point of having just some of > them. > I don't know why but this description (and subject) looks odd to me. I would put something like (if I understood it): "Programs listed in noinst_PROGRAMS inherit default rule/settings to list all tests program also in this macro" > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxx> > --- > server/tests/Makefile.am | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am > index 15196f9..007930c 100644 > --- a/server/tests/Makefile.am > +++ b/server/tests/Makefile.am > @@ -35,6 +35,12 @@ LDADD = \ > $(SPICE_NONPKGCONFIG_LIBS) \ > $(NULL) > > +TESTS = \ > + stat_test \ > + stream-test \ > + test-qxl-parsing \ > + $(NULL) > + Why did you moved above? This just make the patch bigger. > noinst_PROGRAMS = \ > test_display_no_ssl \ > test_display_streaming \ > @@ -47,14 +53,7 @@ noinst_PROGRAMS = \ > test_vdagent \ > test_display_width_stride \ > spice-server-replay \ > - stream-test \ > - stat_test \ > - $(NULL) > - > -TESTS = \ > - stat_test \ > - test-qxl-parsing \ > - stream-test \ > + $(TESTS) \ > $(NULL) > > check_PROGRAMS = $(TESTS) > -- > 2.5.0 > > Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel